exeptions.wh1 request#2
Open
lbrdev wants to merge 1 commit intoChangeRequest:masterfrom
lbrdev:master
Open
Conversation
didva
requested changes
Jan 10, 2017
Contributor
didva
left a comment
didva
left a comment
There was a problem hiding this comment.
Go on with other tasks.
The main idea of bank account is correct.
| public static void main(String[] args) { | ||
| BankAccountImpl bankAccount1 = new BankAccountImpl(); | ||
|
|
||
| bankAccount1.balance = 15; |
Contributor
There was a problem hiding this comment.
Please always use getters/setters. Direct access to fields is really bad practice.
|
|
||
| @Override | ||
| public void setRate(double rate) { | ||
| rate = newRate; |
Contributor
There was a problem hiding this comment.
Looks strange and for sure won't work.
| double balance; | ||
| double rate; | ||
| int accountNumber; | ||
| double sum; |
Contributor
There was a problem hiding this comment.
Please make all fields private and delete sum and newRate fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to check 1